Tweak some defaults: macro_names, operator_spaces, no_space, function_naming_convention, module_naming_convention, no_debug_call
#358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new regex is almost as permissive as the old one, but doesn't allow for __, for example
Also test {left, ":"}, {right, ":"} by using the defaults directly
Make it ^[a-z](_?[a-z0-9]+)*$ I also "fix" it by removing _SUITE (?) Did this ever make sense?
Make it ^[a-z](_?[a-z0-9]+)*(_SUITE)?$ Actually, with this change a previously invalid module name (used in tests) is now valid, but I think it's something we actually want: think handler_for_ok_200; this should be allowed
elbrujohalcon
approved these changes
Sep 17, 2024
elbrujohalcon
referenced
this pull request
Sep 17, 2024
Update atom naming convention with a more relaxed regex
|
Strange that this is flagged as merged and closed 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion under the issue this closes. Closes #234.
Documentation and migration guide are updated.
Further considerations
Potentially best reviewed on a commit-by-commit basis: everything except the documentation updates is pretty isolated.