Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markaddonizio documentation 1 #18

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

markaddonizio
Copy link
Contributor

Updated documentation (readme) to match metadata, taking advice to have a bigger version jump.

@markaddonizio markaddonizio requested a review from a team October 9, 2023 16:00
@markaddonizio markaddonizio self-assigned this Oct 9, 2023
@canihavethisone
Copy link
Contributor

canihavethisone commented Oct 15, 2023

Thanks @markaddonizio , looking forward to this release. 2 quick things:

  1. Could the puppet version (in Metadata) be lifted to <9.0.0 so it declares compatibility with v8? Your tests should be raised to use the Puppet 7 & 8 versions to do so. Drop support for EOL Puppet v6 also.
  2. I think the version update should be a major one, to v3.0.0. For example, the Vox release guidance suggests that dropping a Puppet version is a major version bump https://voxpupuli.org/docs/releasing_version/

@canihavethisone
Copy link
Contributor

canihavethisone commented Oct 15, 2023

Hey again @markaddonizio, I have created another PR that lifts the supported Puppet puppet versions to 7 & 8, and therefore with a major version bump.

I have updated the changelog. However the travis file needs updating IF it is used

@markaddonizio markaddonizio merged commit aa1c31a into master Oct 23, 2023
@markaddonizio markaddonizio deleted the markaddonizio-documentation-1 branch October 23, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants