Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edge): need to set end block for http #673

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix(edge): need to set end block for http #673

merged 2 commits into from
Sep 4, 2024

Conversation

devanbenz
Copy link
Contributor

  • typo when creating the initial PR
  • Need to set up the end before the liveness probe or else it gets caught up in the https enabled false and you cannot set it

jdockerty
jdockerty approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@jdockerty jdockerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple fix 🚀

@devanbenz devanbenz merged commit 5f35c9b into master Sep 4, 2024
2 checks passed
@devanbenz devanbenz deleted the allow-http-ear-5445 branch September 4, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdockerty jdockerty jdockerty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devanbenz @jdockerty