Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testcontainers/testcontainer-go has been renamed to testcontainers/testcontainers-go #11199

Closed
F21 opened this issue Jan 17, 2019 · 6 comments
Closed
Assignees
Milestone

Comments

@F21
Copy link

F21 commented Jan 17, 2019

https://github.com/testcontainers/testcontainer-go has been renamed to https://github.com/testcontainers/testcontainers-go

I was having issues with Go modules and discovered that the testcontainer-go repo was renamed to testcontainers-go while trying to import hashicorp/vault/api whose repo requires the influxdb repo.

I didn't have time to familiar myself with influxdb nor its code base, so I don't have a PR available. On the surface it doesn't seem to be a massive change, but I am not sure if testcontainers-go also broke other interfaces with this change.

@vangent
Copy link

vangent commented Jan 23, 2019

I ran into this too.

I tried to create a PR to fix it but I get a weird exec: "bzr": executable file not found in $PATH error when building. The README references this but only says how to fix on MacOS; I'm on Linux.

@F21
Copy link
Author

F21 commented Jan 23, 2019

@vangent You need to install bazaar (which is a VCS similar to git). On Ubuntu, I ran sudo apt install bzr.

@vangent
Copy link

vangent commented Jan 24, 2019

I spent some time trying to get this to work and failed. The code using testcontainers-go doesn't seem to be run during tests. I also got errors like this:

go: verifying github.com/docker/docker@v1.13.1: checksum mismatch                                                                                   
        downloaded: h1:5VBhsO6ckUxB0A8CE5LlUJdXzik9cbEbBTQ/ggeml7M=                                                                                 
        go.sum:     h1:IkZjBSIc8hBjLpqeAbeE5mca5mNgeatLHBy3GO78BWo=                                                                                 

@F21
Copy link
Author

F21 commented Jan 24, 2019

@vangent I have seen similar issues before. I believe part of the problem is because there was some changes to how the checksum was calculated between certain Go 1.11 patch releases. My usual fix is to delete everything in $GOPATH/pkg/mod/ and try again. If it doesn't work, then delete the go.sum file and go mod should regenerate it.

@vangent
Copy link

vangent commented Jan 24, 2019

Sorry, I'm not comfortable doing that for someone else's project. This should be a trivial change for a regular contributor;
https://github.com/influxdata/influxdb/blob/master/vault/secret_test.go#L13

just needs to be updated to reference github.com/testcontainers/testcontainers-go (note the extra "s").

@leodido leodido self-assigned this Jan 24, 2019
leodido added a commit that referenced this issue Jan 24, 2019
Fixes #11199

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
leodido added a commit that referenced this issue Jan 24, 2019
Fixes #11199

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@mark-rushakoff
Copy link
Contributor

go: verifying github.com/docker/docker@v1.13.1: checksum mismatch

The correct solution here is to upgrade to the most recent version of Go (1.11.5), since old versions (1.11.0 - 1.11.3) calculated the checksum incorrectly. After upgrading, you probably need to run go clean -modcache so that your system pulls the repository again and calculates the checksum correctly.

@russorat russorat added this to the Alpha milestone Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants