feat: vendor pbjson-types descriptor set (#62) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah this is a good alternative too 👍 |
tustvold
force-pushed
the
vendor-descriptor-set
branch
2 times, most recently
from
00a2498
to
901fe13
Compare
tustvold
force-pushed
the
vendor-descriptor-set
branch
from
901fe13
to
aa21d11
Compare
crepererum
approved these changes
Oct 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #78 for avoiding the need for users to have protoc installed to compile pbjson-types.
My main reservation with vendoring the generated code is that it would make it non-trivial to add feature flags to pbjson-types configure the generated code, e.g. using BTreeMap or Bytes, etc... I also happen to prefer not vendoring generated code into git repositories where possible.
@rnarubin what do you think about this?