-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mac signing issue with arm64 #10293
Conversation
resolve linter issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for figuring this out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work and a big thank you for the clean-up. This should make this easier in the future if we ever need to debug any issues! Two small changes, otherwise this is good to go.
Co-authored-by: Joshua Powers <powersj@influxdata.com>
Co-authored-by: Joshua Powers <powersj@influxdata.com>
👍 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
Co-authored-by: Joshua Powers <powersj@influxdata.com> (cherry picked from commit b672de3)
Co-authored-by: Joshua Powers <powersj@influxdata.com>
The arm64 binary failed to get signed during the release because by default Go gives an ad hoc signature to arm64 binaries because Mac requires a signed binary with arm64 otherwise all Go binaries will fail (thread about this here: golang/go#42684). Therefore in order to overwrite the ad hoc sig with our influxdata signature we needed to provide the flag
--force
to the codesign tool. This pull requests adds the required--force
flag and refactored the mac signing shell script. All linter issues found by shellcheck were addressed, more information is printed out for future debugging, and I updated the script to stop changing directories and instead use absolute paths to make it easier to read.This was tested by changing the circleci config to only build and sign the mac artifacts, you can see the results here:
you can find the artifacts that include the signed dmg files here: