Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2726 - IdsDataGrid dropdown editor async beforecelledit #2804

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

jdilag90
Copy link
Collaborator

@jdilag90 jdilag90 commented Sep 6, 2024

Explain the details for making this change. What existing problem does the pull request solve?
Users can now pass an async function or Promise to the vetoable beforecelledit event's response callback.
This allows user to perform aync operations like database fetches before vetoing beforecelledit event.
image

Related github/jira issue (required):
Closes #2726

Steps necessary to review your pull request (required):

  1. Checkout branch
  2. Go to http://localhost:4300/ids-data-grid/beforecelledit-async.html
  3. Test bookCurrency column dropdowns and make sure dropdown options load properly
  4. Test http://localhost:4300/ids-data-grid/editable.html for any regressions

Included in this Pull Request:

  • Some documentation for the feature.
  • A test for the bug or feature.
  • A note to the change log.

@jdilag90 jdilag90 requested a review from a team as a code owner September 6, 2024 16:22
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-09-09.at.5.22.41.PM.mov

@ericangeles ericangeles merged commit 8381360 into main Sep 9, 2024
4 checks passed
@ericangeles ericangeles deleted the 2726-dropdown-editor-beforecelledit branch September 9, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdsDropdown Editor - Options set are not showing at first time if is set after a delay in an event
4 participants