Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc - Add fixes and tests for popups and fix text color #2805

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

Fixes three items as noted in the steps.

Related github/jira issue (required):
Closes https://inforwiki.atlassian.net/browse/IDS-4665
Closes https://inforwiki.atlassian.net/browse/IDS-4660
Closes https://inforwiki.atlassian.net/browse/IDS-4264
Closes #2561

Steps necessary to review your pull request (required):

IDS-4665

IDS-4660

IDS-4264

Included in this Pull Request:

  • A test for the bug or feature.
  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner September 6, 2024 18:01
@jdilag90
Copy link
Collaborator

jdilag90 commented Sep 6, 2024

Looks good, found one thing which could be another ticket

Tooltip positiong is off when hovering over show/hide button. It also reveals hidden password.
Happens on main.wc as well.
Maybe we just disable tooltips for password inputs?
image

Copy link
Collaborator

@jdilag90 jdilag90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

Made another for tooltip issue mentioned above (#2810)

Copy link
Contributor

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on my end.

image image image

Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image image image image image image image

Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image image image image image image image image

@tmcconechy tmcconechy merged commit a2e526f into main Sep 9, 2024
4 checks passed
@tmcconechy tmcconechy deleted the lookup-fixes branch September 9, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdsLookup: filter popup is not aligned - BETA 1.3
5 participants