CPU poseidon hash #611
Open
CPU poseidon hash #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CI passing like that
Default on is necessary when loading a pre-built backend to avoid link errors.
mickeyasa
reviewed
Sep 12, 2024
mickeyasa
reviewed
Sep 12, 2024
| const unsigned int nof_partial_rounds, | ||
| const unsigned int nof_upper_full_rounds, | ||
| const unsigned int nof_end_full_rounds, | ||
| const S* rounds_constants, |
There was a problem hiding this comment.
if you provide 4 arrays, why do you need the struct PoseidonConstants?
There was a problem hiding this comment.
You wanted to put all matrices and round consts in a structure
mickeyasa
reviewed
Sep 12, 2024
mickeyasa
reviewed
Sep 12, 2024
| const unsigned int m_nof_partial_rounds; ///< Partial number of rounds of this Poseidon hash. | ||
| const unsigned int m_nof_upper_full_rounds; ///< Number of full rounds at the beginning of this Poseidon hash. | ||
| const unsigned int m_nof_end_full_rounds; ///< Number of full rounds at the end of this Poseidon hash. | ||
| PoseidonConstants<S> m_poseidon_constants; ///< Structure that holds Poseidon hash round constants and MDS matrix values. |
There was a problem hiding this comment.
Isn't it going to be more comfortable to just save the 4 vectors instead of this class?
There was a problem hiding this comment.
What do you mean? What class?
mickeyasa
reviewed
Sep 12, 2024
mickeyasa
reviewed
Sep 12, 2024
mickeyasa
reviewed
Sep 12, 2024
mickeyasa
reviewed
Sep 12, 2024
| tmp_col_res[col_idx] = tmp_col_res[col_idx] + vec_in[row_idx] * matrix_in[row_idx * arity + col_idx]; | ||
| } | ||
| } | ||
| for (int col_idx = 0; col_idx < arity; col_idx++) { |
|
comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR for CPU Poseidon hash (single hash and multiple hashes).
Linked Issues
Resolves #