Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Android Gradle Plugin conditionally #594

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Load Android Gradle Plugin conditionally #594

merged 1 commit into from
Mar 5, 2020

Conversation

SaeedZhiany
Copy link
Contributor

  • Load Android Gradle Plugin conditionally

This wraps the Android Gradle plugin dependency in the buildscripts section of android/build.gradle in a conditional:

if (project == rootProject) {
    // ... (dependency here)
}

The Android Gradle plugin is only required when opening the project stand-alone, not when it is included as a dependency. By doing this, the project opens correctly in Android Studio, and it can also be consumed as a native module dependency from an application project without affecting the app project (avoiding unnecessary downloads/conflicts/etc).

for more info, you can refer to this thread and especially this comment.

  • Removed unnecessary buildToolsVersion

according to this documentation, it's no longer need to specify buildToolsVersion in gradle file. so I removed it.

Removed unnecessary buildToolsVersion
@marcosinigaglia marcosinigaglia merged commit c3c3d2a into innoveit:master Mar 5, 2020
@marcosinigaglia
Copy link
Member

Thanks

@SaeedZhiany SaeedZhiany deleted the patch-1 branch March 5, 2020 13:49
anwarhamr pushed a commit to anwarhamr/react-native-ble-manager that referenced this pull request May 7, 2020
Load Android Gradle Plugin conditionally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants