Convert skeleton to use niv #262
Conversation
| # Use nixpkgs pin from commonLib | ||
| , pkgs ? commonLib.pkgs | ||
| , sourcesOverride ? {} | ||
| , pkgs ? import ./nix { |
There was a problem hiding this comment.
Do you think the filename should be ./nix/nixpkgs.nix rather than ./nix/default.nix?
Could we also add a comment saying that this argument is the Nixpkgs package set, augmented with iohk-nix overlays.
There was a problem hiding this comment.
Added comments!
I'm a bit ambivalent on nix/nixpkgs.nix, it is probably more explicit, but also more verbose and in some projects (like cardano-ops) we import ../nix {} at numerous places. Also using nix/default.nix seems to be the convention used by projects using niv, eg.:
There was a problem hiding this comment.
FWIW, I agree with Rodney that I'd prefer nix/default.nix. We use niv and we don't even have a special file for the nixpkgs, we just pull it out and do pkgs = import (sources.nixpkgs) {... }.
| # Use nixpkgs pin from commonLib | ||
| , pkgs ? commonLib.pkgs | ||
| , sourcesOverride ? {} | ||
| , pkgs ? import ./nix { |
There was a problem hiding this comment.
FWIW, I agree with Rodney that I'd prefer nix/default.nix. We use niv and we don't even have a special file for the nixpkgs, we just pull it out and do pkgs = import (sources.nixpkgs) {... }.
| inherit system crossSystem config nixpkgsOverlays; | ||
| sourcesOverride = sources; | ||
| }; | ||
| pkgs = iohkNix.pkgs; |
There was a problem hiding this comment.
I still really dislike the weird proxying of the nixpkgs arguments through iohk-nix, but I guess that's orthogonal to this PR.
There was a problem hiding this comment.
yeah, would probably be best if iohk-nix expose an iohk-overlays and a iohk-config. and people use them explicitly.
| "url": "https://github.com/input-output-hk/niv/archive/89da7b2e7ae0779fd351618fc74df1b1da5e6214.tar.gz", | ||
| "url_template": "https://github.com/<owner>/<repo>/archive/<rev>.tar.gz" | ||
| }, | ||
| "nixpkgs": { |
There was a problem hiding this comment.
I take it this is just here to make niv happy? Wish they would do nmattia/niv#134 already...
There was a problem hiding this comment.
indeed, otherwise we have to rely on <nixpkgs>.
|
bors r+ |
Build succeeded |
No description provided.