This repository has been archived by the owner on Jun 17, 2020. It is now read-only.
[DEVOPS-32] ensure pkgs/default.nix is up to date #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleverca22
force-pushed
the
stack2nix-travis-testing
branch
10 times, most recently
from
d164420
to
edad927
Compare
|
and 2 more edge cases,
i also had an idea on how to perform stack2nix testing under hydra, just flag it as a fixed-output derivation, because we want the output to be "no differences found", and any deviation from that is a failure
|
cleverca22
force-pushed
the
stack2nix-travis-testing
branch
3 times, most recently
from
bc83c63
to
345c739
Compare
cleverca22
changed the title
domenkozar
reviewed
Jun 26, 2017
.travis.yml
Outdated
| @@ -5,6 +5,10 @@ env: | |||
|
|
|||
| install: | |||
| - nix-env -iA nixopsUnstable -f '<nixpkgs>' | |||
| - echo "binary-caches = https://cache.nixos.org https://hydra.iohk.io" > ~/nix.conf | |||
| - echo "binary-cache-public-keys = hydra.iohk.io:f/Ea+s+dFdN+3Y/G+FDgSq+a5NEWhJGzdjvKNGv0/EQ= cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=" > ~/nix.conf | |||
| - export NIX_CONF_DIR=~ | |||
There was a problem hiding this comment.
This is a bad idea since the default file does bring some sanity things.
Try to workaround the 14.04 bug by doing - export PYTHONPATH=
domenkozar
reviewed
Jun 26, 2017
jobsets/cardano.nix
Outdated
| @@ -17,4 +16,5 @@ in rec { | |||
| ]; | |||
| }).config.system.build.amazonImage; | |||
| tests = import ./../tests { inherit pkgs supportedSystems; }; | |||
| #stack2nix-output = callPackage ./check-stack2nix.nix { inherit (iohkpkgs) stack2nix; }; | |||
There was a problem hiding this comment.
This won't work since stack2nix is very impure, let's remove it from here :)
domenkozar
reviewed
Jun 26, 2017
scripts/check-stack2nix.sh
Outdated
|
|
||
| time nix-build -A stack2nix -o $scriptDir/stack2nix -Q -j 4 | ||
|
|
||
| time $scriptDir/stack2nix/bin/stack2nix --revision 4bcf1e6b601d531f753ebdb6aec23e19d4b08e6c https://github.com/input-output-hk/cardano-sl.git > $scriptDir/default-2.nix |
There was a problem hiding this comment.
I was hoping we could just run pkgs/generate.sh and check git diff to have no output. Then we wouldn't need this script at all. Am I missing something with that approach?
cleverca22
force-pushed
the
stack2nix-travis-testing
branch
9 times, most recently
from
1f4a456
to
8e55aea
Compare
cleverca22
changed the title
cleverca22
force-pushed
the
stack2nix-travis-testing
branch
from
8e55aea
to
78e528f
Compare
|
@cleverca22 let's try rebasing this on top of latest master to see what happens :) |
cleverca22
changed the title
cleverca22
force-pushed
the
stack2nix-travis-testing
branch
7 times, most recently
from
c5a11ae
to
e05ef15
Compare
cleverca22
force-pushed
the
stack2nix-travis-testing
branch
3 times, most recently
from
8c42c6e
to
4cd692e
Compare
cleverca22
force-pushed
the
stack2nix-travis-testing
branch
from
4cd692e
to
c06bc33
Compare
cleverca22
changed the title
|
@domenkozar all checks are now passing and the PR looks good to me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found an edgecase in testing this, updating
pkgs/default.nixchanges the build of stack2nix, and now travis cant use the cached copy, so it needs a PR built by hydra