feat(nami): await posthog events that occur before window.close

Window.close could occur before the posthog event is sent. Await on sending the event before closing the window.
input-output-hk · Oct 9, 2024 · 0cac72b · 0cac72b
1 parent 0b918d6
commit 0cac72b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/packages/nami/src/ui/app/pages/dapp-connector/enable.tsx b/packages/nami/src/ui/app/pages/dapp-connector/enable.tsx
@@ -112,8 +112,8 @@ export const Enable = ({
         <Button
           height={'50px'}
           width={'180px'}
-          onClick={() => {
-            capture(Events.DappConnectorAuthorizeDappCancelClick);
+          onClick={async () => {
+            await capture(Events.DappConnectorAuthorizeDappCancelClick);
             controller('deny', dappInfo?.url ?? '', () => {
               window.close();
             });
@@ -126,8 +126,8 @@ export const Enable = ({
           height={'50px'}
           width={'180px'}
           colorScheme="teal"
-          onClick={() => {
-            capture(Events.DappConnectorAuthorizeDappAuthorizeClick);
+          onClick={async () => {
+            await capture(Events.DappConnectorAuthorizeDappAuthorizeClick);
             controller('allow', dappInfo?.url ?? '', () => {
               window.close();
             });

diff --git a/packages/nami/src/ui/app/pages/dapp-connector/signData.tsx b/packages/nami/src/ui/app/pages/dapp-connector/signData.tsx
@@ -201,7 +201,7 @@ export const SignData = ({ dappConnector, account }: Readonly<Props>) => {
                 height={'50px'}
                 width={'180px'}
                 onClick={async () => {
-                  capture(Events.DappConnectorDappDataCancelClick);
+                  await capture(Events.DappConnectorDappDataCancelClick);
                   await request?.reject(() => {
                     window.close();
                   });
@@ -247,7 +247,7 @@ export const SignData = ({ dappConnector, account }: Readonly<Props>) => {
         }}
         onConfirm={async (status, signedMessage) => {
           if (status) {
-            capture(Events.DappConnectorDappDataConfirmClick);
+            await capture(Events.DappConnectorDappDataConfirmClick);
             const channelCloseDelay = 100;
             setTimeout(() => {
               window.close();

diff --git a/packages/nami/src/ui/app/pages/dapp-connector/signTx.tsx b/packages/nami/src/ui/app/pages/dapp-connector/signTx.tsx
@@ -471,7 +471,7 @@ export const SignTx = ({
                 height={'50px'}
                 width={'180px'}
                 onClick={async () => {
-                  capture(Events.DappConnectorDappTxCancelClick);
+                  await capture(Events.DappConnectorDappTxCancelClick);
                   await request?.reject(() => {
                     window.close();
                   });
@@ -487,7 +487,7 @@ export const SignTx = ({
                 colorScheme="teal"
                 onClick={() => {
                   capture(Events.DappConnectorDappTxSignClick);
-                  ref.current?.openModal(account.index);
+                  (ref.current as any)?.openModal(account.index);
                 }}
               >
                 Sign
@@ -517,7 +517,7 @@ export const SignTx = ({
         }}
         onConfirm={async (status, signedTx) => {
           if (status) {
-            capture(Events.DappConnectorDappTxConfirmClick);
+            await capture(Events.DappConnectorDappTxConfirmClick);
           }
 
           const channelCloseDelay = 100;