Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [LW-11556] add tests for advanced mode receive screen #1444

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

ljagiela
Copy link
Contributor

No description provided.

@ljagiela ljagiela requested review from a team as code owners September 24, 2024 14:24
@ljagiela ljagiela force-pushed the LW-11556/advanced_mode_receive_tests branch from 7543fa8 to 81ced94 Compare September 24, 2024 19:12
@ljagiela ljagiela force-pushed the LW-11556/advanced_mode_receive_tests branch from 81ced94 to b0f3cc9 Compare September 25, 2024 07:18
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Sep 25, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 8d381e07

passed failed skipped flaky total result
Total 32 0 4 0 36

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we could have separate class to cover POM for address card to avoid chaining of elements within assertions e.g. await unusedAddressCard.$(WalletAddressPage.ADDRESS_CARD_TITLE).waitForDisplayed({ reverse: true });. This could be handled as an enhancement.

Copy link

sonarcloud bot commented Sep 25, 2024

Copy link
Collaborator

@mchappell mchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ljagiela ljagiela merged commit 62bfcee into main Sep 25, 2024
30 of 31 checks passed
@ljagiela ljagiela deleted the LW-11556/advanced_mode_receive_tests branch September 25, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants