Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension): shared wallets feature flags are now controlled via PostHog #1448

Conversation

AngelCastilloB
Copy link
Member

Currently the Shared Wallet feature is behind a build time feature flag

We’re looking to make this feature part of the new opt-in beta program, which requires it to be upgraded to a runtime feature flag, controlled remotely via PostHog

Checklist

  • JIRA - <link>
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Read the flag from posthog

@AngelCastilloB AngelCastilloB requested a review from a team as a code owner September 26, 2024 05:54
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Sep 26, 2024

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 1b0cb453

passed failed skipped flaky total result
Total 32 0 4 0 36

@AngelCastilloB AngelCastilloB force-pushed the feat/lw-11515-replace-shared-wallet-hardcoded-feature-flag-with-posthog branch 4 times, most recently from 8dc2acd to 5c58da0 Compare September 27, 2024 02:37
@AngelCastilloB AngelCastilloB force-pushed the feat/lw-11515-replace-shared-wallet-hardcoded-feature-flag-with-posthog branch from 5c58da0 to 47dcca4 Compare September 30, 2024 03:09
@AngelCastilloB AngelCastilloB requested a review from a team as a code owner September 30, 2024 03:09
@AngelCastilloB AngelCastilloB force-pushed the feat/lw-11515-replace-shared-wallet-hardcoded-feature-flag-with-posthog branch from 47dcca4 to 1b0cb45 Compare September 30, 2024 07:16
Copy link

sonarcloud bot commented Sep 30, 2024

@AngelCastilloB AngelCastilloB merged commit 603b620 into main Sep 30, 2024
29 checks passed
@AngelCastilloB AngelCastilloB deleted the feat/lw-11515-replace-shared-wallet-hardcoded-feature-flag-with-posthog branch September 30, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants