Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-6076 Allow metadata tags that are longer than 64 characters. #627

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

jhbertra
Copy link
Contributor

  • Adds new metadata version 2 with new tag encoding to disambiguate from old encoding
  • Encodes tags as either a text or a list of text chunked by 64 characters.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
    • Reviewer requested

@jhbertra jhbertra requested a review from nhenin June 22, 2023 21:14
@jhbertra jhbertra changed the title PLT-6076 metadata tag length PLT-6076 Allow metadata tags that are longer than 64 characters. Jun 22, 2023
@jhbertra jhbertra changed the base branch from main to plt-5378-status-api June 22, 2023 21:15
Base automatically changed from plt-5378-status-api to main June 22, 2023 21:29
@nhenin
Copy link
Contributor

nhenin commented Jun 23, 2023

@jhbertra FYI, you have your tests failing for the same reasons we discussed this week. (I'm re-running them...)
https://github.com/input-output-hk/marlowe-cardano/actions/runs/5350390372/jobs/9702926203?pr=627

  test/Language/Marlowe/Runtime/CliSpec.hs:189:3: 
  1) Language.Marlowe.Runtime.Cli, Marlowe runtime CLI, create, generates a create tx body envelope
       uncaught exception: TestnetException
       TestnetException:
         exception: 'user error (Error creating database: "ERROR:  source database \"template1\"
           is being accessed by other users\nDETAIL:  There is 1 other session using the
           database.\n")'
         workspace: /tmp/workspaces/local-testnet-50d6e3e3-b5b6-46aa-b050-c21202d12014

@jhbertra jhbertra force-pushed the plt-6076-metadata-tag-length branch from 2a18df1 to 1e44f88 Compare June 23, 2023 12:30
@jhbertra jhbertra merged commit 6bf8009 into main Jun 23, 2023
1 of 2 checks passed
@jhbertra jhbertra deleted the plt-6076-metadata-tag-length branch June 23, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants