Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guidelines #1305

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 18, 2023

Content

This PR includes updated contributing guidelines with a mention to the facts that all commits must be signed in order to be merged in the main branch of the repository.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Added a mention to the facts that all commits must be signed.
@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Test Results

    3 files  ±0    17 suites  ±0   5m 39s ⏱️ -22s
699 tests ±0  690 ✔️  - 9  0 💤 ±0  9 +9 
757 runs  ±0  748 ✔️  - 9  0 💤 ±0  9 +9 

For more details on these failures, see this check.

Results for commit 8c9cc1b. ± Comparison against base commit f7f1415.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud merged commit ac51892 into main Oct 18, 2023
23 of 26 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/fix-contributing-guidelines branch October 18, 2023 15:17
@jpraynaud jpraynaud temporarily deployed to testing-preview October 18, 2023 15:22 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants