Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mithril-common publication on crates.io #1372

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Nov 27, 2023

Content

This PR includes a fix to the process to publish mithril-common on crates.io: the OpenAPI specs file must be published with the package on crates.io so that the build script that computes available API versions.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Nov 27, 2023
Copy link

github-actions bot commented Nov 27, 2023

Test Results

    3 files  ±0    30 suites  ±0   7m 27s ⏱️ -45s
736 tests ±0  736 ✔️ ±0  0 💤 ±0  0 ±0 
844 runs  ±0  844 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit dd421cf. ± Comparison against base commit 4042937.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/fix-build-script-mithril-common-crate branch from d901188 to 0152af4 Compare November 27, 2023 17:59
@jpraynaud jpraynaud force-pushed the jpraynaud/fix-build-script-mithril-common-crate branch from 0152af4 to dd421cf Compare November 28, 2023 09:07
@jpraynaud jpraynaud merged commit 951bc02 into main Nov 28, 2023
30 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/fix-build-script-mithril-common-crate branch November 28, 2023 11:10
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
…d/fix-build-script-mithril-common-crate

Fix `mithril-common` publication on crates.io
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
…d/fix-build-script-mithril-common-crate

Fix `mithril-common` publication on crates.io
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
…d/fix-build-script-mithril-common-crate

Fix `mithril-common` publication on crates.io
falcucci pushed a commit to falcucci/mithril that referenced this pull request Nov 28, 2023
…d/fix-build-script-mithril-common-crate

Fix `mithril-common` publication on crates.io
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants