Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runbook for 'Mithril client multi-platform test' #1534

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Feb 27, 2024

Content

This PR includes a new runbook for the 'Mithril client multi-platform test' manual workflow.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1530

@dlachaume dlachaume self-assigned this Feb 27, 2024
Copy link

github-actions bot commented Feb 27, 2024

Test Results

  3 files   42 suites   8m 45s ⏱️
871 tests 871 ✅ 0 💤 0 ❌
960 runs  960 ✅ 0 💤 0 ❌

Results for commit b4f55d7.

♻️ This comment has been updated with latest results.

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just few typos to fix below.

docs/runbook/test-client-multiplatform/README.md Outdated Show resolved Hide resolved
docs/runbook/test-client-multiplatform/README.md Outdated Show resolved Hide resolved
docs/runbook/README.md Outdated Show resolved Hide resolved
@dlachaume dlachaume force-pushed the damien/1530/add-runbook-client-multi-platform-tests branch from 9ca0ad9 to a89388e Compare February 27, 2024 11:01
@dlachaume dlachaume force-pushed the damien/1530/add-runbook-client-multi-platform-tests branch from a89388e to b4f55d7 Compare February 27, 2024 13:57
@dlachaume dlachaume merged commit c31e492 into main Feb 27, 2024
40 of 46 checks passed
@dlachaume dlachaume deleted the damien/1530/add-runbook-client-multi-platform-tests branch February 27, 2024 14:08
@dlachaume dlachaume mentioned this pull request Feb 27, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a runbook for running Client multi-platform tests
2 participants