Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: post Chang hard fork cleanup #1912

Merged
merged 9 commits into from
Sep 4, 2024
Merged

Chore: post Chang hard fork cleanup #1912

merged 9 commits into from
Sep 4, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Sep 3, 2024 •
edited
Loading

Content

This PR includes a cleanup of the CI and devnet following the activation of the Chang hard fork on the Cardano mainnet:

  • Minimum Cardano version is now 9.0.0:
    • Previous versions have been removed from the CI
    • Previous versions hacks have been removed in the devnet
    • Previous Cardano configurations in infra have been removed
  • Era transitions tests in the CI are not needed anymore and have been removed (they will be reactivated in preparation of the next epoch when it is announced)

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1910

@jpraynaud jpraynaud self-assigned this Sep 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

Test Results

    4 files  ±0     53 suites  ±0   9m 28s ⏱️ -6s
1 247 tests ±0  1 247 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 458 runs  ±0  1 458 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 56d9d39. ± Comparison against base commit ffc7943.

♻️ This comment has been updated with latest results.

@jpraynaud
feat: update e2e tests Cardano node versions in CI
1aaa3f0 
Following the 'Chang' hard fork which activates the 'Conway' era,
we don't need to support versions which do not work any more on Cardano networks.
@jpraynaud
chore: upgrade default version of Cardano node in e2e test
e644856 
From '9.1.0' to '9.1.1'.
@jpraynaud
chore: remove hacks for Cardano '8.1.2' in devnet
7e268b7
@jpraynaud
chore: remove hacks for Cardano '8.8.0+' in devnet
3825714
@jpraynaud jpraynaud force-pushed the jpraynaud/1910-post-chang-hard-fork-cleanup branch from 2dea68d to c6f3b88 Compare September 3, 2024 14:49
Alenar
Alenar approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a little cleanup is always welcomed 🧹 !

mithril-test-lab/mithril-devnet/VERSION Outdated Show resolved Hide resolved
@jpraynaud jpraynaud force-pushed the jpraynaud/1910-post-chang-hard-fork-cleanup branch from c6f3b88 to 0a38da4 Compare September 4, 2024 07:42
sfauvel
sfauvel approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud force-pushed the jpraynaud/1910-post-chang-hard-fork-cleanup branch from 0a38da4 to 56d9d39 Compare September 4, 2024 08:09
@jpraynaud jpraynaud merged commit 1beeae8 into main Sep 4, 2024
39 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1910-post-chang-hard-fork-cleanup branch September 4, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpraynaud @Alenar @sfauvel