Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add infinite Cardano transactions preloader in signer #1921

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Feat: add infinite Cardano transactions preloader in signer #1921

merged 5 commits into from
Sep 9, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Sep 6, 2024 •
edited
Loading

Content

This PR includes an infinite preloader of Cardano transactions in the signer.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1920

@jpraynaud jpraynaud self-assigned this Sep 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

Test Results

    4 files  ±0     53 suites  ±0   9m 26s ⏱️ -5s
1 247 tests ±0  1 247 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 458 runs  ±0  1 458 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b77e52e. ± Comparison against base commit 8690abe.

♻️ This comment has been updated with latest results.

sfauvel
sfauvel approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mithril-signer/src/main.rs Outdated Show resolved Hide resolved
@jpraynaud jpraynaud force-pushed the jpraynaud/1920-infinite-preloader-signer branch from c220bd9 to b77e52e Compare September 9, 2024 13:56
@jpraynaud jpraynaud merged commit ffdab78 into main Sep 9, 2024
39 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1920-infinite-preloader-signer branch September 9, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Cardano transactions preloading infinite in signer
4 participants
@jpraynaud @Alenar @sfauvel @dlachaume