Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: hydra CI error when allow lint attribute specifies a reason #1960

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Sep 26, 2024

Content

This PR fix an error detailed in the draft issue.

The linting reason has been removed, as it's still experimental and cannot be applied yet.

The initial error from Hydra CI: https://github.com/input-output-hk/mithril/pull/1948/checks?check_run_id=30529857732

error[E0658]: lint reasons are experimental
  --> mithril-common/src/logging.rs:31:9
   |
31 |         reason = "A field is needed to add the lifetime but is unused"
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #54503 <https://github.com/rust-lang/rust/issues/54503> for more information

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@dlachaume dlachaume self-assigned this Sep 26, 2024
@dlachaume dlachaume changed the title fix: replace allow with expect to specify linting reason Fix: hydra CI error when allow lint attribute specifies a reason Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

Test Results

    4 files  ±0     54 suites  ±0   9m 36s ⏱️ -1s
1 299 tests ±0  1 299 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 510 runs  ±0  1 510 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 69fc137. ± Comparison against base commit e4e7404.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the dlachaume/stabilize-lint-reasons branch from a05c959 to 09be856 Compare September 26, 2024 10:47
@dlachaume dlachaume marked this pull request as ready for review September 26, 2024 10:53
@dlachaume dlachaume merged commit fcdd144 into main Sep 26, 2024
45 checks passed
@dlachaume dlachaume deleted the dlachaume/stabilize-lint-reasons branch September 26, 2024 15:13
@Alenar Alenar mentioned this pull request Sep 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants