Fix source-repo under Cabal 3.4 generated plans #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are no longer always local: haskell/cabal@2b6cd51 haskell/cabal#5586
puffnfresh
commented
Jul 7, 2021
| (_, "local", "local", _) -> Just $ Package | ||
| extras = fmap Just $ filterInstallPlan $ \pkg -> case ( pkg ^. key "style" . _String | ||
| , pkg ^. key "pkg-src" . key "type" . _String) of | ||
| ("local", "local") -> Just $ Package |
There was a problem hiding this comment.
I'm actually not sure why we care about the style at all. Wouldn't pkg-src be the only important thing?
There was a problem hiding this comment.
It seems like style is now directly derived from pkg-src, from my understanding of the Cabal code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are no longer always local:
haskell/cabal@2b6cd51
haskell/cabal#5586