Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support qualified type names in the Access Grant client #1409

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

acoburn
Copy link
Collaborator

@acoburn acoburn commented Jul 11, 2024

At present, the AccessGrantClient processes Access Credentials with either the shorter localname (e.g. SolidAccessGrant, SolidAccessRequest, SolidAccessDenial) or the fully qualified name (e.g. http://www.w3.org/ns/solid/vc#SolidAccessGrant). There are cases where a qualified name, such as vc:AccessGrantDenial, will be returned from an Access Grant server, and these should be supported as well.

Resolves #1407

Specifically, this adds support for qualified type names with the vc: prefix across the various Access Grant types. In addition, the testing has been expanded to include better coverage of SolidAccessDenial types.

@acoburn acoburn requested a review from a team as a code owner July 11, 2024 17:00
@inrupt-sonarqube-for-github
Copy link

@acoburn acoburn enabled auto-merge (squash) July 11, 2024 17:14
Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acoburn acoburn merged commit a7c13bf into main Jul 11, 2024
10 checks passed
@acoburn acoburn deleted the vc-types branch July 11, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response to denyAccess causes exception
2 participants