createEmptyContainerAt() and createEmptyContainerInContainer() #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f81969d:
|
Vinnl
changed the title
NSeydoux
approved these changes
Aug 18, 2020
Unfortunately it does not support the spec-supported method of creating a Container: nodeSolidServer/node-solid-server#1465 As a workaround, we create a dummy file within the Container we want to create, which should lead to the server creating the Container on the fly. The dummy file is then immediately deleted again. Although this method theoretically works for other servers as well, it is a bit cumbersome and more error-prone due to the multiple consecutive requests. Therefore I decided to use it specifically when we detect NSS's message about not supporting the spec-prescribed method of creating a Container, so that it can be easily removed wholesale once NSS is no longer a problem, and the implementation does not surprise other contributors.
Vinnl
force-pushed
the
feat/1238-empty-container
branch
from
8a29512
to
f81969d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature description
This adds the ability to initialise a new Container in the Pod, and returns a SolidDataset that can be modified to add additional properties to the Container.
It adds a specific workaround for NSS, which does not support creating Containers using PUT, as mandated by the spec: nodeSolidServer/node-solid-server#1465
It also adds a small workaround for ESS, which currently expects a Link header.
Do note that ESS does currently have a bug that causes it to return a 412 Precondition Failed after creating the Container (even though it does properly create the Container) when using
createEmptyContainerAt.Checklist
index.ts, if applicable.