Server timing header #1617
Server timing header #1617
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
=========================================
Coverage 78.34% 78.34%
- Complexity 2495 2517 +22
=========================================
Files 256 257 +1
Lines 8177 8247 +70
Branches 977 983 +6
=========================================
+ Hits 6406 6461 +55
- Misses 1352 1360 +8
- Partials 419 426 +7 |
There was a problem hiding this comment.
Reviewed 15 of 16 files at r2, all commit messages.
Reviewable status: 15 of 16 files reviewed, 1 unresolved discussion (waiting on @EddeCCC)
inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/instrumentation/hook/actions/span/ContinueOrStartSpanAction.java line 180 at r2 (raw file):
} if (name == null) { if(methodInfo != null)
these can be combined
|
|
||
| if(inspectitConfig == null) return; | ||
| int sessionLimit = inspectitConfig.getExporters().getTags().getHttp().getSessionLimit(); | ||
| sessionStorage.setSessionLimit(sessionLimit); |
There was a problem hiding this comment.
Updates of exporter properties will restart the exporter. Thus, no updates have to be done in the scheduled method.
|
There was a problem hiding this comment.
Reviewable status: 14 of 29 files reviewed, 2 unresolved discussions (waiting on @TitusLabs)
inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/instrumentation/hook/actions/span/ContinueOrStartSpanAction.java line 180 at r2 (raw file):
Previously, TitusLabs (Titus Meyer) wrote…
these can be combined
Done.
There was a problem hiding this comment.
Reviewed 13 of 15 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @EddeCCC)
inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/exporter/BrowserPropagationServlet.java line 0 at r4 (raw file):
Where's the check for allowed origins?
There was a problem hiding this comment.
Reviewable status: 23 of 29 files reviewed, 2 unresolved discussions (waiting on @TitusLabs)
inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/exporter/BrowserPropagationServlet.java line at r4 (raw file):
Previously, TitusLabs (Titus Meyer) wrote…
Where's the check for allowed origins?
Done.
There was a problem hiding this comment.
Reviewed 10 of 10 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
Add new function getTraceContext() in InspectitContextImpl to extract the trace context and use it inside actions
This change is