Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send writes without consistency due to missing coordinator write metr… #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

serban21
Copy link

…ics at table level before Cassandra 4. Also add support for C*4 CoordinatorWriteLatency

Closes #63

…ics at table level before Cassandra 4. Also add support for C*4 CoordinatorWriteLatency
@zegelin
Copy link

zegelin commented Feb 21, 2020

@serban21 Thanks for the PR.

I'll have to give some more thought to this before I merge it. I made some changes late last year to explicitly exclude read and write metrics, since they are aggregates of the per-consistency-level metrics.

@serban21
Copy link
Author

@zegelin yes, I saw that. I wrote on the PR why I think it's needed. Since then I looked a bit more into this, and I found out that ClientRequest metrics are separated by consistency level only since Cassandra 3.10 (see https://issues.apache.org/jira/browse/CASSANDRA-7384 and apache/cassandra@221f27a).

So on any version before 3.10 there is only the total write, which will be excluded due to the consistency == null test. And per-table writes are available only from Cassandra 4.

A better solution might be to check if the version is less than 3.10, and emit the write metrics only in this case. The version is available in StorageService getReleaseVersion, and it can be compared by using the CassandraVersion class. How does this sound?

@zegelin
Copy link

zegelin commented Feb 24, 2020

Sounds reasonable.

Some thought will need to be given to how multiple C* versions are supported going forward. I'd like to avoid peppering the code with version tests, where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing cordinator write metrics on C*3
2 participants