Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use python specific naming on GH PR eventlistener & co #519

Merged
merged 1 commit into from
Apr 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .tekton/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,6 @@ Ensure that the ping is received from GitHub, and that it is filtered out so
a simple ping event does not trigger any `PipelineRun` unnecessarily.

````bash
eventlistener_pod=$(kubectl get pods -o jsonpath='{range .items[*]}{.metadata.name}{"\n"}{end}' | grep el-github-pr)
kubectl logs "${eventlistener_pod}" | grep 'event type ping is not allowed'
eventlistener_pod=$(kubectl get pods -o jsonpath='{range .items[*]}{.metadata.name}{"\n"}{end}' | grep el-github-pr-python-eventlistener-)
kubectl logs -f "${eventlistener_pod}" | grep 'event type ping is not allowed'
````
10 changes: 5 additions & 5 deletions .tekton/github-pr-eventlistener.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: triggers.tekton.dev/v1beta1
kind: TriggerTemplate
metadata:
name: github-pr-pipeline-template
name: github-pr-python-tracer-pipeline-template
spec:
params:
- description: The git branch name
Expand Down Expand Up @@ -41,7 +41,7 @@ spec:
apiVersion: triggers.tekton.dev/v1beta1
kind: TriggerBinding
metadata:
name: github-pr-binding
name: github-pr-python-tracer-binding
spec:
params:
- name: git-branch
Expand All @@ -56,7 +56,7 @@ spec:
apiVersion: triggers.tekton.dev/v1beta1
kind: EventListener
metadata:
name: github-pr-eventlistener
name: github-pr-python-eventlistener
spec:
serviceAccountName: tekton-triggers-eventlistener-serviceaccount
triggers:
Expand Down Expand Up @@ -97,6 +97,6 @@ spec:
# The git branch name shortened and converted to RFC 1123 subdomain names
expression: 'body.pull_request.head.ref.truncate(38).lowerAscii().translate("_", "-")'
bindings:
- ref: github-pr-binding
- ref: github-pr-python-tracer-binding
template:
ref: github-pr-pipeline-template
ref: github-pr-python-tracer-pipeline-template
6 changes: 3 additions & 3 deletions .tekton/github-webhook-ingress.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: github-webhook-ingress
name: github-pr-python-webhook-ingress
spec:
ingressClassName: public-iks-k8s-nginx
tls:
Expand All @@ -11,10 +11,10 @@ spec:
- host: <ENTER_YOUR_DOMAIN_NAME_HERE>
http:
paths:
- path: /hooks
- path: /github-pr-python-hooks
pathType: Exact
backend:
service:
name: el-github-pr-eventlistener
name: el-github-pr-python-eventlistener
port:
number: 8080
Loading