Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTel] Refactor Django instrumentation #590

Merged
merged 5 commits into from
Aug 23, 2024
Merged

[OTel] Refactor Django instrumentation #590

merged 5 commits into from
Aug 23, 2024

Conversation

GSVarsha
Copy link
Contributor

@GSVarsha GSVarsha commented Aug 20, 2024 •
edited
Loading

Signed-off-by: Varsha GS varsha.gs@ibm.com

coverage: 95%

@GSVarsha GSVarsha changed the base branch from master to otel_migration August 20, 2024 04:36
@GSVarsha GSVarsha added Review & Merge OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry labels Aug 20, 2024
@GSVarsha GSVarsha self-assigned this Aug 20, 2024
@GSVarsha GSVarsha added this to the H2-2024 milestone Aug 20, 2024
@GSVarsha GSVarsha marked this pull request as ready for review August 21, 2024 07:21
pvital
pvital requested changes Aug 22, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few requests. The last one you can ignore if you want.

tests/apps/app_django.py Outdated Show resolved Hide resolved
tests/frameworks/test_django.py Outdated Show resolved Hide resolved
tests/frameworks/test_django.py Show resolved Hide resolved
Varsha GS added 3 commits August 22, 2024 20:19
django: refactor instrumentation
b2c14cc 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
django: Adapt tests after refactor
237e5ae 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
tests(django): increase coverage
5a774d4 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha requested a review from pvital August 22, 2024 15:05
Varsha GS added 2 commits August 23, 2024 14:38
sdk_span: Add OTel SpanKind to entry and exit kind
2e4fbab 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
style(django): Add style changes
d122b70 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
pvital
pvital approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha merged commit 54a00c9 into otel_migration Aug 23, 2024
7 of 8 checks passed
@GSVarsha GSVarsha deleted the otel-django-instrumentation branch August 23, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvital pvital pvital approved these changes

@CagriYonca CagriYonca Awaiting requested review from CagriYonca

Assignees

@GSVarsha GSVarsha

Labels
OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry Review & Merge
Projects
None yet
Milestone
H2-2024
Development

Successfully merging this pull request may close these issues.
2 participants
@GSVarsha @pvital