Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTel] Sanic instrumentation #613

Merged
merged 3 commits into from
Sep 17, 2024
Merged

[OTel] Sanic instrumentation #613

merged 3 commits into from
Sep 17, 2024

Conversation

GSVarsha
Copy link
Contributor

@GSVarsha GSVarsha commented Sep 9, 2024 •
edited
Loading

coverage: 97%

Signed-off-by: Varsha GS varsha.gs@ibm.com

@GSVarsha GSVarsha added wip work in progress currency OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry labels Sep 9, 2024
@GSVarsha GSVarsha added this to the H2-2024 milestone Sep 9, 2024
@GSVarsha GSVarsha self-assigned this Sep 9, 2024
@GSVarsha GSVarsha force-pushed the otel-sanic-instrumentation branch 6 times, most recently from 009c180 to 6ff67a1 Compare September 11, 2024 08:26
@GSVarsha GSVarsha removed the wip work in progress label Sep 11, 2024
@GSVarsha GSVarsha marked this pull request as ready for review September 11, 2024 08:31
pvital
pvital requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

src/instana/instrumentation/sanic_inst.py Outdated Show resolved Hide resolved
src/instana/instrumentation/sanic_inst.py Outdated Show resolved Hide resolved
CagriYonca
CagriYonca reviewed Sep 12, 2024
View reviewed changes
src/instana/instrumentation/sanic_inst.py Show resolved Hide resolved
src/instana/instrumentation/sanic_inst.py Show resolved Hide resolved
src/instana/instrumentation/sanic_inst.py Show resolved Hide resolved
src/instana/util/traceutils.py Outdated Show resolved Hide resolved
Varsha GS added 2 commits September 16, 2024 15:36
feat: enable auto-instrumentation with middleware for sanic
c3b00bd 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
(cherry picked from commit fb29c79)
sanic: refactor tests
6bafd3c 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
(cherry picked from commit b4968d0)
sanic: use the lightweight sanic_testing module
0be4b79 
(cherry picked from commit 6ff67a1)
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
pvital
pvital approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha merged commit b3c35b3 into otel_migration Sep 17, 2024
8 of 9 checks passed
@GSVarsha GSVarsha deleted the otel-sanic-instrumentation branch September 17, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvital pvital pvital approved these changes

@CagriYonca CagriYonca Awaiting requested review from CagriYonca

Assignees

@GSVarsha GSVarsha

Labels
currency OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry
Projects
None yet
Milestone
H2-2024
Development

Successfully merging this pull request may close these issues.
3 participants
@GSVarsha @pvital @CagriYonca