Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTel] Pyramid instrumentation #619

Merged
merged 4 commits into from
Sep 21, 2024
Merged

[OTel] Pyramid instrumentation #619

merged 4 commits into from
Sep 21, 2024

Conversation

GSVarsha
Copy link
Contributor

@GSVarsha GSVarsha commented Sep 12, 2024 •
edited
Loading

  • enable auto-instrumentation
  • consider both implicit and explicit tween ordering

coverage: 96%

Signed-off-by: Varsha GS varsha.gs@ibm.com

@GSVarsha GSVarsha added wip work in progress OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry labels Sep 12, 2024
@GSVarsha GSVarsha added this to the H2-2024 milestone Sep 12, 2024
@GSVarsha GSVarsha self-assigned this Sep 12, 2024
@GSVarsha GSVarsha marked this pull request as ready for review September 17, 2024 14:30
@GSVarsha GSVarsha removed the wip work in progress label Sep 17, 2024
CagriYonca
CagriYonca reviewed Sep 18, 2024
View reviewed changes
src/instana/__init__.py Outdated Show resolved Hide resolved
src/instana/instrumentation/pyramid_inst.py Outdated Show resolved Hide resolved
src/instana/instrumentation/pyramid_inst.py Outdated Show resolved Hide resolved
src/instana/instrumentation/pyramid_inst.py Outdated Show resolved Hide resolved
src/instana/instrumentation/pyramid_inst.py Outdated Show resolved Hide resolved
src/instana/instrumentation/pyramid_inst.py Outdated Show resolved Hide resolved
tests/frameworks/test_pyramid.py Show resolved Hide resolved
Varsha GS added 3 commits September 20, 2024 13:05
refactor: pyramid tween instrumentation
73e302f 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
(cherry picked from commit 8ab3210)
pyramid: adapt tests after refactor
1a00249 
(cherry picked from commit 126e4ec)
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
pyramid: enable auto-instrumentation
112e062 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
pvital
pvital requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

src/instana/instrumentation/pyramid_inst.py Outdated Show resolved Hide resolved
src/instana/instrumentation/pyramid_inst.py Outdated Show resolved Hide resolved
pyramid: change from sdk span (http) to registered entry span (wsgi)
10f6291 
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
pvital
pvital approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha merged commit 863cf9b into otel_migration Sep 21, 2024
8 of 9 checks passed
@GSVarsha GSVarsha deleted the otel-pyramid-instrumentation branch September 21, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvital pvital pvital approved these changes

@CagriYonca CagriYonca Awaiting requested review from CagriYonca

Assignees

@GSVarsha GSVarsha

Labels
enhancement OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry Review & Merge
Projects
None yet
Milestone
H2-2024
Development

Successfully merging this pull request may close these issues.
3 participants
@GSVarsha @pvital @CagriYonca