Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove TestAgent from the production code. #622

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

pvital
Copy link
Member

@pvital pvital commented Sep 19, 2024

Remove the TestAgent and the if-blocks that check if running in a test environment from the production code.

FINALLY

@pvital pvital self-assigned this Sep 19, 2024
@pvital pvital added enhancement Review & Merge OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry labels Sep 19, 2024
Remove the TestAgent and the if-blocks that check if running in a test
environment from the production code.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ✨

@pvital pvital merged commit c66ce2c into otel_migration Sep 20, 2024
8 of 9 checks passed
@pvital pvital deleted the otel_no_env_is_test branch September 20, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry Review & Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants