Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTel] Guarantee autoprofile tests after OTel migration. #625

Merged
merged 2 commits into from
Sep 23, 2024
Merged

[OTel] Guarantee autoprofile tests after OTel migration. #625

merged 2 commits into from
Sep 23, 2024
+515 −420

Conversation

pvital
Copy link
Member

@pvital pvital commented Sep 23, 2024

  • Adapted autoprofile files to follow new style guidelines.
  • Adapted autoprofile files to work after OTel migration.
  • Coverage will be handled later.

@pvital pvital self-assigned this Sep 23, 2024
@pvital pvital added Review & Merge OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry labels Sep 23, 2024
CagriYonca
CagriYonca reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@CagriYonca CagriYonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few missing typing annotations

src/instana/autoprofile/schedule.py Outdated Show resolved Hide resolved
tests/autoprofile/test_profiler.py Outdated Show resolved Hide resolved
GSVarsha
GSVarsha approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pvital
style: format autoprofile files.
d279543 
Used ruff (vscode) to:
- Black-compatible code formatting.
- fix all auto-fixable violations, like unused imports.
- isort-compatible import sorting.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
tests(autoprofile): adapt tests to OTel usage.
f9cb5cc 
Used ruff (vscode) to:
- Black-compatible code formatting.
- fix all auto-fixable violations, like unused imports.
- isort-compatible import sorting.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
CagriYonca
CagriYonca approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@CagriYonca CagriYonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvital pvital merged commit ab08720 into otel_migration Sep 23, 2024
7 of 9 checks passed
@pvital pvital deleted the otel_autoprofile_tests branch September 23, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSVarsha GSVarsha GSVarsha approved these changes

@CagriYonca CagriYonca Awaiting requested review from CagriYonca

Assignees

@pvital pvital

Labels
OTel_migration Migration the code dependency from OpenTracing to OpenTelemetry Review & Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvital @CagriYonca @GSVarsha