Skip to content

Commit

Permalink
Revert "Silence an erroneous pylint warning inconsistent-return-state…
Browse files Browse the repository at this point in the history
…ments."

This reverts commit bf62d58.
  • Loading branch information
bilderbuchi committed Mar 17, 2018
1 parent 8b07180 commit 0db033a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
3 changes: 1 addition & 2 deletions instruments/abstract_instruments/comm/file_communicator.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,7 @@ def close(self):
except IOError as e: # pragma: no cover
logger.warning("Failed to close file, exception: %s", repr(e))

def read_raw(self, size=-1): # pylint: disable=inconsistent-return-statements
# TODO: Check if this can be reenabled when pylint>1.8.3 is released
def read_raw(self, size=-1):
"""
Read bytes in from the file.
Expand Down
3 changes: 1 addition & 2 deletions instruments/abstract_instruments/comm/serial_communicator.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,7 @@ def close(self):
finally:
self._conn.close()

def read_raw(self, size=-1): # pylint: disable=inconsistent-return-statements
# TODO: Check if this can be reenabled when pylint>1.8.3 is released
def read_raw(self, size=-1):
"""
Read bytes in from the serial port.
Expand Down
3 changes: 1 addition & 2 deletions instruments/abstract_instruments/comm/socket_communicator.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ def close(self):
finally:
self._conn.close()

def read_raw(self, size=-1): # pylint: disable=inconsistent-return-statements
# TODO: Check if this can be reenabled when pylint>1.8.3 is released
def read_raw(self, size=-1):
"""
Read bytes in from the socket connection.
Expand Down
3 changes: 1 addition & 2 deletions instruments/abstract_instruments/instrument.py
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,7 @@ def write(self, msg):
"""
self._file.write(msg)

def binblockread(self, data_width, fmt=None): # pylint: disable=inconsistent-return-statements
# TODO: Check if this can be reenabled when pylint>1.8.3 is released
def binblockread(self, data_width, fmt=None):
""""
Read a binary data block from attached instrument.
This requires that the instrument respond in a particular manner
Expand Down

0 comments on commit 0db033a

Please sign in to comment.