Update supported Python versions #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This shouldn't impact you, but just tagging just in case @cgranade @crazy4pi314 |
|
I think that makes a lot of sense. Unlike 2.7 → 3.x, there's very little pain in upgrading 3.3 → 3.4, such that putting 3.4 as a minimum requirement for 3.x support seems entirely reasonable. Hopefully we can even take the leap to 3.5 and no 2.7 at some point, so that we can get that sweet |
|
I'm kinda thinking that 2017 might be the last year for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Python 3.6 and drops support for 3.3
The reason for dropping 3.3 support is because
numpy>=1.12doesn't support Py33. Since numpy is currently still a requirement, I think its important that we don't try to downgrade (or change) our users' version of numpy when IK doesn't actually need to.Related issue: #168