Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change write to write_raw when communicating using visa #177

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Change write to write_raw when communicating using visa #177

merged 1 commit into from
Aug 16, 2017

Conversation

VirtualSatai
Copy link
Contributor

The write_raw method should probably call the write_raw method in pyvisa

@coveralls
Copy link

coveralls commented Aug 9, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 85.072% when pulling 82e0b17 on VirtualSatai:master into bc4fdbb on Galvant:master.

@VirtualSatai
Copy link
Contributor Author

Test failure caused by python-quantities/python-quantities#128

@scasagrande
Copy link
Contributor

Hey! Sorry for the delay, busy weekend. Anyways, yeah, the VisaCommunicator looks like it was missed during the work I did to update them all. This class actually needs some tests written, but for now this looks like a good change. I'm going to switch the target branch to develop where the test failure was previously fixed.

@scasagrande scasagrande changed the base branch from master to develop August 15, 2017 02:43
@scasagrande scasagrande merged commit 5a8e546 into instrumentkit:develop Aug 16, 2017
@scasagrande scasagrande mentioned this pull request Aug 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VirtualSatai @coveralls @scasagrande