Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visa readbytes #192

Merged
merged 16 commits into from
Feb 7, 2019
Merged

Fix visa readbytes #192

merged 16 commits into from
Feb 7, 2019

Conversation

scasagrande
Copy link
Contributor

This is an updated version of PR #186 by @littlebrat, which address issue #185. It contains a few small tweaks that address my original PR review comments.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 85.256% when pulling 0a1d315 on fix-visa-readbytes into b5fa44b on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 85.256% when pulling 0a1d315 on fix-visa-readbytes into b5fa44b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 85.256% when pulling 0a1d315 on fix-visa-readbytes into b5fa44b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 85.256% when pulling 0a1d315 on fix-visa-readbytes into b5fa44b on master.

@scasagrande
Copy link
Contributor Author

Coverage drop is acceptable in this case as this functionality will be tested once we have a test file for visa_communicator

@scasagrande scasagrande merged commit 3d9175d into master Feb 7, 2019
@scasagrande scasagrande deleted the fix-visa-readbytes branch February 7, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants