BF APT Thorlabs home_parameters
#338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trappitsch
commented
Mar 25, 2022
| @@ -1407,7 +1407,7 @@ def home_parameters(self, values): | |||
| # replace values that are `None` | |||
| if None in values: | |||
| set_params = self.home_parameters | |||
| values = [x if x else y for x, y in zip(values, set_params)] | |||
| values = [x if x is not None else y for x, y in zip(values, set_params)] | |||
There was a problem hiding this comment.
Here we need to check in fact if x is not None and not just if x, otherwise an offset of zero cannot be set...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bug that I didn't think of: If the user tried to set the home offset value to zero since PR #337, the existing offset was used and not the zero. Will point it out in code. This is now fixed. And tested for!