Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pagination to GetCommit() call #2009

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

rumenvasilev
Copy link
Contributor

Resolves #2005


Before the change?

After the change?

  • Added pagination support which should technically resolve the problem.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

rumenvasilev and others added 2 commits November 9, 2023 17:56
Signed-off-by: Rumen Vasilev <git@rumenvasilev.com>
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kfcampbell kfcampbell merged commit f184099 into integrations:main Nov 13, 2023
3 checks passed
@rumenvasilev rumenvasilev deleted the issue-2005 branch November 13, 2023 20:08
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
Signed-off-by: Rumen Vasilev <git@rumenvasilev.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Pagination issue in github_repository_file data block
2 participants