Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for ray psutil on macOS #2856

Merged
merged 2 commits into from
Sep 12, 2020
Merged

Hotfix for ray psutil on macOS #2856

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbeeee7
Hotfix for ray psutil on macOS
qiyuangong Sep 11, 2020
7ebd0dd
Add try except to catch AccessDenied
qiyuangong Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyzoo/zoo/ray/raycontext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ def kill_redundant_log_monitors(redis_address):
import subprocess
log_monitor_processes = []
for proc in psutil.process_iter(["name", "cmdline"]):
# Avoid throw exception when listing lwsslauncher in macOS
if proc.name == "lwsslauncher":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does filter status == ‘zombie’ work？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe. But sometimes the process you are looking for maybe a zombie process

continue
cmdline = subprocess.list2cmdline(proc.cmdline())
is_log_monitor = "log_monitor.py" in cmdline
is_same_redis = "--redis-address={}".format(redis_address)
Expand Down