Skip to content

Commit

Permalink
checkpatch: stop complaining about tags suggested/tested by syzkaller
Browse files Browse the repository at this point in the history
If you submit a testing request to syzkaller it may reply with:
> syzbot has tested the proposed patch and the reproducer did not \
> trigger any issue:
>
> Reported-and-tested-by: syzbot+f817490f5bd20541b90a@syzkaller.appspotmail.com

Checkpatch is ok with Reported-by tags, but complains about
Reported-and-tested-by tags:
> WARNING: Possible unwrapped commit description (prefer a maximum 75 \
> chars per line)
> torvalds#48:
> Reported-and-tested-by: syzbot+f817490f5bd20541b90a@syzkaller.appspotmail.com

Adding the new tag to signature_tags removes this warning.

Signed-off-by: Andrew Kanner <andrew.kanner@gmail.com>
  • Loading branch information
kanner authored and intel-lab-lkp committed Oct 6, 2023
1 parent 7de25c8 commit 89c59d8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion scripts/checkpatch.pl
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,7 @@ sub hash_show_words {
Tested-by:|
Reviewed-by:|
Reported-by:|
Reported-and-tested-by:|
Suggested-by:|
To:|
Cc:
Expand Down Expand Up @@ -711,7 +712,7 @@ sub find_standard_signature {
my ($sign_off) = @_;
my @standard_signature_tags = (
'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:',
'Reviewed-by:', 'Reported-by:', 'Suggested-by:'
'Reviewed-by:', 'Reported-by:', 'Reported-and-tested-by:', 'Suggested-by:'
);
foreach my $signature (@standard_signature_tags) {
return $signature if (get_edit_distance($sign_off, $signature) <= 2);
Expand Down

0 comments on commit 89c59d8

Please sign in to comment.