Skip to content

Commit

Permalink
add review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
abhilash1910 committed Oct 3, 2024
1 parent e4a9a5b commit faea6e7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 30 deletions.
16 changes: 0 additions & 16 deletions sycl/doc/extensions/supported/sycl_ext_intel_device_info.md
Original file line number Diff line number Diff line change
Expand Up @@ -504,19 +504,3 @@ Then the memory bus width can be obtained using the standard get\_info() interfa
if (dev.has(aspect::ext_intel_memory_bus_width)) {
auto MemoryBusWidth = dev.get_info<ext::intel::info::device::memory_bus_width>();
}

# Deprecated queries #

The table below lists deprecated, that would soon be removed and their replacements:

|Deprecated Descriptors | Replacement Descriptors |
| ------------------------------- |--------------------------- |
| info\:\:device\:\:ext\_intel\_device\_info\_uuid | ext\:\:intel\:\:info\:\:device\:\:uuid |
| info\:\:device\:\:ext\_intel\_pci\_address | ext\:\:intel\:\:info\:\:device\:\:pci\_address |
| info\:\:device\:\:ext\_intel\_gpu\_eu\_simd\_width | ext\:\:intel\:\:info\:\:device\:\:gpu\_eu\_simd\_width |
| info\:\:device\:\:ext\_intel\_gpu\__eu\_count | ext\:\:intel\:\:info\:\:device\:\:gpu\__eu\_count |
| info\:\:device\:\:ext\_intel\_gpu\_slices | ext\:\:intel\:\:info\:\:device\:\:gpu\_slices |
| info\:\:device\:\:ext\_intel\_gpu\_subslices\_per\_slice | ext\:\:intel\:\:info\:\:device\:\:gpu\_subslices\_per\_slice |
|info\:\:device\:\:ext\_intel\_gpu\_eu\_count\_per\_subslice | ext\:\:intel\:\:info\:\:device\:\:gpu\_eu\_count\_per\_subslice |
| info\:\:device\:\:ext\_intel\_gpu\_hw\_threads\_per\_eu | ext\:\:intel\:\:info\:\:device\:\:gpu\_hw\_threads\_per\_eu |
| info\:\:device\:\:ext\_intel\_max\_mem\_bandwidth | ext\:\:intel\:\:info\:\:device\:\:max\_mem\_bandwidth |
14 changes: 0 additions & 14 deletions sycl/include/sycl/info/device_traits_deprecated.def
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,3 @@ __SYCL_PARAM_TRAITS_DEPRECATED(preferred_interop_user_sync,"deprecated in SYCL 2
// Deprecated and not part of SYCL 2020 spec
__SYCL_PARAM_TRAITS_DEPRECATED(image_max_array_size,"support for image arrays has been removed in SYCL 2020")
__SYCL_PARAM_TRAITS_DEPRECATED(opencl_c_version,"use device::get_backend_info instead")

//TODO:Remove when possible
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_pci_address,"use ext::intel::info::device::pci_address instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_gpu_eu_count,"use ext::intel::info::device::gpu_eu_count instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_gpu_eu_simd_width,"use ext::intel::info::device::gpu_eu_simd_width instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_gpu_slices,"use ext::intel::info::device::gpu_slices instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_gpu_subslices_per_slice,"use ext::intel::info::device::gpu_subslices_per_slice instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_gpu_hw_threads_per_eu,"use ext::intel::info::device::gpu_hw_threads_per_eu instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_device_info_uuid,"use ext::intel::info::device::uuid instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_intel_max_mem_bandwidth,"use ext::intel::info::device::max_mem_bandwidth instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_oneapi_max_work_groups_1d,"use ext::oneapi::experimental::info::device::max_work_groups<1> instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_oneapi_max_work_groups_2d,"use ext::oneapi::experimental::info::device::max_work_groups<2> instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_oneapi_max_work_groups_3d,"use ext::oneapi::experimental::info::device::max_work_groups<3> instead")
__SYCL_PARAM_TRAITS_DEPRECATED(ext_oneapi_max_global_work_groups,"use ext::oneapi::experimental::info::device::max_global_work_groups instead")

0 comments on commit faea6e7

Please sign in to comment.