Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][unittests] Several unittests postcommit failures after 9992f2a #13592

Closed
uditagarwal97 opened this issue Apr 30, 2024 · 1 comment · Fixed by #13602
Closed

[SYCL][unittests] Several unittests postcommit failures after 9992f2a #13592

uditagarwal97 opened this issue Apr 30, 2024 · 1 comment · Fixed by #13602
Assignees
@uditagarwal97 @aelovikov-intel
Labels
bug Something isn't working

Comments

@uditagarwal97
Copy link
Contributor

Describe the bug

Fist post commit failure: https://github.com/intel/llvm/actions/runs/8853888908/job/24315708190#step:12:1513 appeared after #13569 got merged.

/__w/llvm/llvm/src/sycl/include/CL/sycl.hpp:12:2: error: #warning is a C++23 extension [-Werror,-Wpedantic]
   12 | #warning "CL/sycl.hpp is deprecated, use sycl/sycl.hpp"
      |  ^
/__w/llvm/llvm/src/sycl/include/CL/sycl.hpp:12:2: error: "CL/sycl.hpp is deprecated, use sycl/sycl.hpp" [-Werror,-W#warnings]

To reproduce

DPC++ commit: 9992f2a

Environment

No response

Additional context

No response
@uditagarwal97 uditagarwal97 added the bug Something isn't working label Apr 30, 2024
@uditagarwal97
Copy link
Contributor Author

@aelovikov-intel FYI. It is weird that we see these failures only in post-commit but not in pre-commit (#13569). I wonder if there's some differences in check-sycl-unittests configuration in pre and post commit.

aelovikov-intel added a commit that referenced this issue Apr 30, 2024
@aelovikov-intel
[SYCL] Silence pedantic warning for #warning directive in `CL/sycl.…
9683832 
…hpp`

Fixes #13592.
@aelovikov-intel aelovikov-intel mentioned this issue Apr 30, 2024
Merged
aelovikov-intel added a commit that referenced this issue Apr 30, 2024
@aelovikov-intel
[SYCL] Silence warnings for #warning directive in CL/sycl.hpp (#1…
e425d2a 
…3602)

Fixes #13592. Also update unittests
not to use the deprecated header file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uditagarwal97 uditagarwal97

@aelovikov-intel aelovikov-intel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SYCL] Silence warnings for #warning directive in CL/sycl.hpp intel/llvm
2 participants
@uditagarwal97 @aelovikov-intel