[CI][HIP] Switch to using 6.1 rocm and make it use a fixed version. #13300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the version was not fixed and could change when rocm latest is updated, which could lead to CI problems. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
aelovikov-intel
approved these changes
Apr 5, 2024
|
@aelovikov-intel The CI is complaining about intel driver install failures even with the latest commit I made where I used the version of the docker build from the sycl branch unchanged. Does some part of the intel driver install need to be updated somehow? |
JackAKirk
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
JackAKirk
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
JackAKirk
changed the title
|
Looks like the update image broke pre-commit CI, I've switched to using latest good image at #13606. @JackAKirk @ldrumm , please follow up on the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the version of ROCM used by docker was not fixed and could change when rocm latest version is updated by AMD, which could lead to CI problems.
This fixes that and sets the version to 6.1.
Only the rocmdev package is installed which is the minimal required package for the compiler. This reduces the memory overhead.