Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC][SYCL][Joint Matrix] Added licence header to tests #13726

Merged
merged 3 commits into from
May 10, 2024

Conversation

artemrad
Copy link
Contributor

@artemrad artemrad commented May 9, 2024

No description provided.

@artemrad artemrad requested a review from a team as a code owner May 9, 2024 14:50
@artemrad artemrad changed the title Added licence header to Joint Matrix tests [SYCL][Joint Matrix] Added licence header to Joint Matrix tests May 9, 2024
@artemrad artemrad changed the title [SYCL][Joint Matrix] Added licence header to Joint Matrix tests [SYCL][Joint Matrix] Added licence header to tests May 9, 2024
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to make the file headers consistent with the coding standard https://llvm.org/docs/CodingStandards.html#file-headers

The other point from the coding standard:
If you are extending, enhancing, or bug fixing already implemented code, use the style that is already being used so that the source is uniform and easy to follow.

Hence, I suggest just follow what we are already using in https://github.com/intel/llvm/tree/sycl/sycl/test-e2e/Matrix, which is

//==----------- element_wise_abc.cpp - DPC++ joint_matrix------------- ----==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

@YuriPlyakhin
Copy link
Contributor

Please, resolve formatting problem. thanks.

Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please, add [NFC] tag to the title of your PR.

@artemrad artemrad changed the title [SYCL][Joint Matrix] Added licence header to tests [NFC][SYCL][Joint Matrix] Added licence header to tests May 9, 2024
@artemrad
Copy link
Contributor Author

@intel/llvm-gatekeepers the PR is ready.

@martygrant martygrant merged commit 144d0f4 into intel:sycl May 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants