Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][NFC] Introduce more helpers to unittests #14716

Conversation

AlexeySachkov
Copy link
Contributor

Introduced a macro to hide bolierplate of specializing KernelInfo structs.
Added a helper function to generate default image to avoid repeating the same code in every test.

Introduced a macro to hide bolierplate of specializing `KernelInfo`
structs.
Added a helper function to generate default image to avoid repeating the
same code in every test.
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlexeySachkov
Copy link
Contributor Author

The failure on CUDA is known and reported in #14715. Considering that this PR only changes unit-tests, I will proceed with merge.

@AlexeySachkov AlexeySachkov merged commit 625ade1 into intel:sycl Jul 23, 2024
15 of 16 checks passed
hdelan pushed a commit to hdelan/llvm that referenced this pull request Jul 26, 2024
Introduced a macro to hide bolierplate of specializing `KernelInfo`
structs.
Added a helper function to generate default image to avoid repeating the
same code in every test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants