-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL]Remove deprecated device traits #15462
base: sycl
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tag @stdale-intel & @gmlueck to confirm that we are ready for this removal.
These APIs have been deprecated for a while, and it would have been OK to remove them in the 2025.0 release, but we missed that window. I think our rules say that we now need to wait for 2026.0 before they can be removed, but maybe @stdale-intel has a different understanding. If we do need to wait, can we change this PR to surround the definitions with the "preview breaking changes" macro? That will remind us to remove them later when 2026.0 comes around. Either way, I think this PR is not complete:
|
Thanks @gmlueck for the review. I think both the points are valid and have made necessary changes to this PR. |
Did @stdale-intel say it was OK to remove these in 2025.1? |
From https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md#deprecated-queries
cc @steffenlarsen