Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add property and version modules #109

Merged
merged 3 commits into from
May 18, 2024
Merged

add property and version modules #109

merged 3 commits into from
May 18, 2024

Conversation

rahulchaphalkar
Copy link
Contributor

  • Add property enum
  • Add version module

@rahulchaphalkar @BTOdell
add property and version modules
fdd0306 
Co-authored-by: Bradley Odell <btodell@hotmail.com>
abrown
abrown approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It occurs to me that we should link to the documentation for these properties in case someone is interested in knowing what they actually do.

crates/openvino/src/property.rs
PropertyKey::RangeForAsyncInferRequests => "RANGE_FOR_ASYNC_INFER_REQUESTS",
PropertyKey::RangeForStreams => "RANGE_FOR_STREAMS",
PropertyKey::DeviceFullName => "FULL_DEVICE_NAME",
PropertyKey::DeviceCapabilities => "OPTIMIZATION_CAPABILITIES",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PropertyKey::DeviceCapabilities => "OPTIMIZATION_CAPABILITIES",
PropertyKey::DeviceCapabilities => "DEVICE_CAPABILITIES",

Typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with property keys where these naming discrepancies between device<->optimization , model<->network exist

crates/openvino/src/property.rs
RwPropertyKey::HintPerformanceMode => "PERFORMANCE_HINT",
RwPropertyKey::HintSchedulingCoreType => "SCHEDULING_CORE_TYPE",
RwPropertyKey::HintInferencePrecision => "INFERENCE_PRECISION_HINT",
RwPropertyKey::HintNumRequests => "PERFORMANCE_HINT_NUM_REQUESTS",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here?

@abrown abrown merged commit 2f5bdd3 into intel:main May 18, 2024
15 checks passed
@abrown abrown deleted the add-enums branch May 18, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrown abrown abrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulchaphalkar @abrown