Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double-check size of returned blob dimensions #58

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Double-check size of returned blob dimensions #58

merged 3 commits into from
Jan 4, 2023

Commits on Jan 4, 2023

  1. Double-check size of returned blob dimensions 

    As discussed [here], this change adds a (perhaps overkill) safety check
of the size of the dimensions array returned by the OpenVINO library.
The added assertion is trying to avoid the improbable case where some
future version of the OpenVINO library returns a dimensions array with
size different than the one auto-generated in the bindings; see `struct
dimensions` in `openvino-sys/src/generated/types.rs`.

[here]: intel#56 (comment)
    @abrown
    abrown committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    512e140 View commit details
    Browse the repository at this point in the history

  2. fix: avoid as_bytes

    @abrown
    abrown committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    a256f28 View commit details
    Browse the repository at this point in the history

  3. fix: use .dims.len()

    @abrown
    abrown committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    2abeb25 View commit details
    Browse the repository at this point in the history