Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: stop creating CRD #761

Closed
pohly opened this issue Oct 1, 2020 · 0 comments · Fixed by #777
Closed

operator: stop creating CRD #761

pohly opened this issue Oct 1, 2020 · 0 comments · Fixed by #777
Labels
bug Something isn't working

Comments

@pohly
Copy link
Contributor

pohly commented Oct 1, 2020

The approach taken by OLM (= aka installation from Operator Hub) is to create the CRD as part of the installation, i.e. the operator doesn't need to create it and also shouldn't delete it. This is more predictable.

We should do the same when installing the operator via YAML and remove the extra code for managing the CRD.
@pohly pohly added the bug Something isn't working label Oct 1, 2020
@pohly pohly mentioned this issue Oct 1, 2020
Closed
5 tasks
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Oct 9, 2020
@avalluri
operator: do not install/uninstall CRD.
a109130 
As per operator developer [best-practices](https://github.com/operator-framework/community-operators/blob/master/docs/best-practices.md)
Operator shall not self-register CRDs. So we stop installing/uninstalling
the Deployment CRD.

FIXES: intel#761
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Oct 9, 2020
@avalluri
operator: do not install/uninstall CRD.
8038494 
As per operator developer [best-practices](https://github.com/operator-framework/community-operators/blob/master/docs/best-practices.md)
Operator shall not self-register CRDs. So we stop installing/uninstalling
the Deployment CRD.

FIXES: intel#761
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Oct 9, 2020
@avalluri
operator: do not install/uninstall CRD.
70aad37 
As per operator developer [best-practices](https://github.com/operator-framework/community-operators/blob/master/docs/best-practices.md)
the operator shall not self-register CRDs. So we stop doing so.

FIXES: intel#761
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Oct 9, 2020
@avalluri
operator: do not install/uninstall CRD.
a31c598 
As per operator developer [best-practices](https://github.com/operator-framework/community-operators/blob/master/docs/best-practices.md)
the operator shall not self-register CRDs. With this change we stop doing so.

FIXES: intel#761
@avalluri avalluri mentioned this issue Oct 9, 2020
Merged
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Oct 13, 2020
@avalluri
operator: do not install/uninstall CRD.
854248f 
As per operator developer [best-practices](https://github.com/operator-framework/community-operators/blob/master/docs/best-practices.md)
the operator shall not self-register CRDs. With this change we stop doing so.

FIXES: intel#761
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Oct 13, 2020
@avalluri
operator: do not install/uninstall CRD.
65c6c4b 
As per operator developer [best-practices](https://github.com/operator-framework/community-operators/blob/master/docs/best-practices.md)
the operator shall not self-register CRDs. With this change we stop doing so.

FIXES: intel#761
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Oct 13, 2020
@avalluri
operator: do not install/uninstall CRD.
04af169 
As per operator developer [best-practices](https://github.com/operator-framework/community-operators/blob/master/docs/best-practices.md)
the operator shall not self-register CRDs. With this change we stop doing so.

FIXES: intel#761
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Oct 14, 2020
@avalluri
operator: do not install/uninstall CRD.
673dc37 
As per operator developer [best-practices](https://github.com/operator-framework/community-operators/blob/master/docs/best-practices.md)
the operator shall not self-register CRDs. With this change we stop doing so.

FIXES: intel#761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

operator: do not install/uninstall CRD. avalluri/pmem-CSI
1 participant
@pohly